From 336102363962bf0ab66b0720749f6956449e8623 Mon Sep 17 00:00:00 2001 From: zzainoo Date: Sun, 20 Feb 2022 03:27:18 +0300 Subject: [PATCH] add checks before make filter kwargs --- rest_framework/generics.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rest_framework/generics.py b/rest_framework/generics.py index c80f5b202..7be68398b 100644 --- a/rest_framework/generics.py +++ b/rest_framework/generics.py @@ -98,6 +98,7 @@ class GenericAPIView(views.APIView): (self.__class__.__name__, lookup_url_kwarg) ) filter_kwargs = {self.lookup_field: self.kwargs[lookup_url_kwarg]} + obj = get_object_or_404(queryset, **filter_kwargs) else: @@ -108,9 +109,10 @@ class GenericAPIView(views.APIView): (self.__class__.__name__, lookup_arg) ) - filter_kwargs = {self.lookup_field: self.request.GET[lookup_arg]} + filter_args = {self.lookup_field: self.request.GET[lookup_arg]} + obj = get_object_or_404(queryset, **filter_args) + - obj = get_object_or_404(queryset, **filter_kwargs) # May raise a permission denied self.check_object_permissions(self.request, obj)