encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-09-16 17:22:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

PUT returns a 201 status when instance was created.

Browse Source 
Note: This behavior is still idempotent, as the state of the system is the same after multiple PUT requests as it is after one.  However, it is helpful to know whether an instance was created or whether it already existed.
This commit is contained in:
Mjumbe Wawatu Poe 2012-08-25 10:54:21 -04:00
parent 912a897e2d
commit 3cef6bd02c
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
djangorestframework/mixins.py
View File

@ -181,7 +181,7 @@ class RequestMixin(object):
return parser.parse(stream) return parser.parse(stream)
raise ErrorResponse(status.HTTP_415_UNSUPPORTED_MEDIA_TYPE, raise ErrorResponse(status.HTTP_415_UNSUPPORTED_MEDIA_TYPE,
{'detail': 'Unsupported media type in request \'%s\'.' % {'detail': 'Unsupported media type in request \'%s\'.' %
content_type}) content_type})
@property @property
@ -522,14 +522,14 @@ class ExistingInstanceMixin (object):
""" """
Assume a single instance for the view. Caches the instance object on self. Assume a single instance for the view. Caches the instance object on self.
""" """
def get_instance(self): def get_instance(self):
if not hasattr(self, 'model_instance'): if not hasattr(self, 'model_instance'):
query_kwargs = self.get_query_kwargs( query_kwargs = self.get_query_kwargs(
self.request, *self.args, **self.kwargs) self.request, *self.args, **self.kwargs)
self.model_instance = self.get_queryset().get(**query_kwargs) self.model_instance = self.get_queryset().get(**query_kwargs)
return self.model_instance return self.model_instance
def get_instance_or_404(self): def get_instance_or_404(self):
model = self.resource.model model = self.resource.model
@ -538,7 +538,7 @@ class ExistingInstanceMixin (object):
except model.DoesNotExist: except model.DoesNotExist:
raise ErrorResponse(status.HTTP_404_NOT_FOUND) raise ErrorResponse(status.HTTP_404_NOT_FOUND)
class ReadModelMixin(ModelMixin, ExistingInstanceMixin): class ReadModelMixin(ModelMixin, ExistingInstanceMixin):
""" """
Behavior to read a `model` instance on GET requests Behavior to read a `model` instance on GET requests
@ -602,10 +602,13 @@ class UpdateModelMixin(ModelMixin, ExistingInstanceMixin):
for (key, val) in self.CONTENT.items(): for (key, val) in self.CONTENT.items():
setattr(self.model_instance, key, val) setattr(self.model_instance, key, val)
self.model_instance.save()
return self.model_instance
except model.DoesNotExist: except model.DoesNotExist:
self.model_instance = model(**self.get_instance_data(model, self.CONTENT, *args, **kwargs)) self.model_instance = model(**self.get_instance_data(model, self.CONTENT, *args, **kwargs))
self.model_instance.save() self.model_instance.save()
return self.model_instance return Response(status.HTTP_201_CREATED, self.model_instance)
class DeleteModelMixin(ModelMixin, ExistingInstanceMixin): class DeleteModelMixin(ModelMixin, ExistingInstanceMixin):