encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-02-02 20:54:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix ModelSerializer logic for fields with default value, which should have required=False set

Browse Source
This commit is contained in:
Tom Christie 2012-10-24 20:58:10 +01:00
parent 0aed70dc8b
commit 3e751ccd8a
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
rest_framework/serializers.py
View File

@ -406,6 +406,10 @@ class ModelSerializer(Serializer):
""" """
Creates a default instance of a basic non-relational field. Creates a default instance of a basic non-relational field.
""" """
kwargs = {}
if model_field.has_default():
kwargs['required'] = False
field_mapping = { field_mapping = {
models.FloatField: FloatField, models.FloatField: FloatField,
models.IntegerField: IntegerField, models.IntegerField: IntegerField,
@ -421,14 +425,9 @@ class ModelSerializer(Serializer):
models.BooleanField: BooleanField, models.BooleanField: BooleanField,
} }
try: try:
ret = field_mapping[model_field.__class__]() return field_mapping[model_field.__class__](**kwargs)
except KeyError: except KeyError:
ret = ModelField(model_field=model_field) return ModelField(model_field=model_field, **kwargs)
if model_field.default is not None:
ret.required = False
return ret
def restore_object(self, attrs, instance=None): def restore_object(self, attrs, instance=None):
""" """