From 458ea844a43b249117c92841bfe95a70a035ae21 Mon Sep 17 00:00:00 2001 From: Ryan P Kilby Date: Wed, 11 Dec 2019 02:39:39 -0800 Subject: [PATCH] Simplify choices in test --- tests/schemas/test_openapi.py | 2 +- tests/schemas/views.py | 13 ++----------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/tests/schemas/test_openapi.py b/tests/schemas/test_openapi.py index 937c4c4f7..d31ce3e0a 100644 --- a/tests/schemas/test_openapi.py +++ b/tests/schemas/test_openapi.py @@ -585,7 +585,7 @@ class TestOperationIntrospection(TestCase): responses = inspector._get_responses(path, method) response_schema = responses['200']['content']['application/json']['schema'] properties = response_schema['items']['properties'] - assert 'type' in properties['gender'] + assert 'type' in properties['choice_field'] def test_serializer_validators(self): path = '/' diff --git a/tests/schemas/views.py b/tests/schemas/views.py index d40d0ab21..7f9867e83 100644 --- a/tests/schemas/views.py +++ b/tests/schemas/views.py @@ -138,22 +138,13 @@ class ExampleValidatedAPIView(generics.GenericAPIView): return Response(serializer.data) -MALE = 'male' -FEMALE = 'female' - -EXAMPLE_GENDER_CHOICES = ( - (MALE, 'male'), - (FEMALE, 'female') -) - - class ExampleChoiceFieldSerializer(serializers.Serializer): - gender = serializers.ChoiceField(choices=EXAMPLE_GENDER_CHOICES) + choice_field = serializers.ChoiceField(choices=[('a', 'Choice A', 'b', 'Choice B')]) class ExampleChoiceFieldAPIView(generics.GenericAPIView): serializer_class = ExampleChoiceFieldSerializer def get(self, *args, **kwargs): - serializer = self.get_serializer(gender='male') + serializer = self.get_serializer(choice_field='a') return Response(serializer.data)