added comment why m2m fields are saved after instance

This commit is contained in:
Krystof Rehacek 2019-06-20 11:52:00 +02:00
parent 177949472c
commit 4871372e24

View File

@ -982,6 +982,9 @@ class ModelSerializer(Serializer):
instance.save() instance.save()
# Note that many-to-many fields are set after updating instance.
# Setting m2m fields triggers signals which could potentialy change
# updated instance and we do not want it to collide with .update()
for attr, value in m2m_fields: for attr, value in m2m_fields:
field = getattr(instance, attr) field = getattr(instance, attr)
field.set(value) field.set(value)