From 4bbc689ec5b442b2424086b21d1aed352bc96e8b Mon Sep 17 00:00:00 2001 From: Saadullah Aleem Date: Thu, 11 May 2023 01:33:19 +0500 Subject: [PATCH] fix formatting issues for list serializer validation fix --- rest_framework/serializers.py | 2 +- tests/test_serializer.py | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index fb2a5bd1e..9301484dc 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -592,7 +592,7 @@ class ListSerializer(BaseSerializer): if kwargs.get('instance', []) and kwargs.get('data', []): assert len(kwargs.get("data", [])) == len( - kwargs.get("instance", [])), 'Data and instance should have same length' + kwargs.get("instance", [])), 'Data and instance should have same length' super().__init__(*args, **kwargs) self.child.bind(field_name='', parent=self) diff --git a/tests/test_serializer.py b/tests/test_serializer.py index 0f57ba6d2..cfa2e838c 100644 --- a/tests/test_serializer.py +++ b/tests/test_serializer.py @@ -2,6 +2,7 @@ import inspect import pickle import re import sys +import unittest from collections import ChainMap from collections.abc import Mapping @@ -10,7 +11,6 @@ from django.db import models from rest_framework import exceptions, fields, relations, serializers from rest_framework.fields import Field - from .models import ( ForeignKeyTarget, NestedForeignKeySource, NullableForeignKeySource ) @@ -787,9 +787,6 @@ class MyClassSerializer(serializers.ModelSerializer): return value -import unittest - - class TestMultipleObjectsValidation(unittest.TestCase): def setUp(self): self.objs = [ @@ -818,10 +815,10 @@ class TestMultipleObjectsValidation(unittest.TestCase): def test_exception_raised_when_data_and_instance_length_different(self): with self.assertRaises(AssertionError): - serializer = MyClassSerializer( + MyClassSerializer( data=[{'value': 'set', 'id': instance.id} for instance in self.objs], instance=self.objs[:-1], many=True, partial=True, - ) \ No newline at end of file + )