encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-27 07:34:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Updated NestedBoundField as_form_field to handle None

Browse Source 
This fixes the html rendering of a nested bound field that is allowed to be null.

For example, if my API has related model serialisers, sort of like this:

class PersonSerializer(serializers.HyperlinkedModelSerializer):
    class Meta:
        model = Person
        fields = ('id', 'url', 'first_name', 'last_name')

class GunSerializer(serializers.HyperlinkedModelSerializer):
    pointing_at = PersonSerializer(many=False, allow_null=True, required=False)
    
    class Meta:
        model = Gun
        fields = ('id', 'url', 'brand', 'pointing_at')

The 'pointing_at' field becomes a NestedBoundField. The API works fine with the null reference in the 'json-only' form (i.e. ?format=json). However, when the HTML form tries to render, I get an error 'NoneType' object has no attribute 'items'.

This change prevents the FOR loop from attempting to access .items() on the self.value when it is None.

NB: This does not fix the issue with rendering the put-object-form correctly. Perhaps there should be a mechanism to allow the PrimaryKeyRelatedField HTML picker?
This commit is contained in:
andrewdodd 2015-10-01 11:13:03 +02:00
parent 689afd83cc
commit 4edf446692
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
rest_framework/utils/serializer_helpers.py
View File

@ -108,11 +108,12 @@ class NestedBoundField(BoundField):
def as_form_field(self):
values = {}
for key, value in self.value.items():
if isinstance(value, (list, dict)):
values[key] = value
else:
values[key] = '' if value is None else force_text(value)
if self.value:
for key, value in self.value.items():
if isinstance(value, (list, dict)):
values[key] = value
else:
values[key] = '' if value is None else force_text(value)
return self.__class__(self._field, values, self.errors, self._prefix)