mirror of
https://github.com/encode/django-rest-framework.git
synced 2025-02-09 08:00:52 +03:00
Do not treat empty non-form input as HTML. (#4566)
This commit is contained in:
parent
26e51ecd6c
commit
5677d063d8
|
@ -299,7 +299,10 @@ class Request(object):
|
||||||
stream = None
|
stream = None
|
||||||
|
|
||||||
if stream is None or media_type is None:
|
if stream is None or media_type is None:
|
||||||
empty_data = QueryDict('', encoding=self._request._encoding)
|
if media_type and not is_form_media_type(media_type):
|
||||||
|
empty_data = QueryDict('', encoding=self._request._encoding)
|
||||||
|
else:
|
||||||
|
empty_data = {}
|
||||||
empty_files = MultiValueDict()
|
empty_files = MultiValueDict()
|
||||||
return (empty_data, empty_files)
|
return (empty_data, empty_files)
|
||||||
|
|
||||||
|
|
|
@ -8,6 +8,7 @@ from django.contrib.auth.models import User
|
||||||
from django.shortcuts import redirect
|
from django.shortcuts import redirect
|
||||||
from django.test import TestCase, override_settings
|
from django.test import TestCase, override_settings
|
||||||
|
|
||||||
|
from rest_framework import fields, serializers
|
||||||
from rest_framework.decorators import api_view
|
from rest_framework.decorators import api_view
|
||||||
from rest_framework.response import Response
|
from rest_framework.response import Response
|
||||||
from rest_framework.test import (
|
from rest_framework.test import (
|
||||||
|
@ -37,10 +38,22 @@ def redirect_view(request):
|
||||||
return redirect('/view/')
|
return redirect('/view/')
|
||||||
|
|
||||||
|
|
||||||
|
class BasicSerializer(serializers.Serializer):
|
||||||
|
flag = fields.BooleanField(default=lambda: True)
|
||||||
|
|
||||||
|
|
||||||
|
@api_view(['POST'])
|
||||||
|
def post_view(request):
|
||||||
|
serializer = BasicSerializer(data=request.data)
|
||||||
|
serializer.is_valid(raise_exception=True)
|
||||||
|
return Response(serializer.validated_data)
|
||||||
|
|
||||||
|
|
||||||
urlpatterns = [
|
urlpatterns = [
|
||||||
url(r'^view/$', view),
|
url(r'^view/$', view),
|
||||||
url(r'^session-view/$', session_view),
|
url(r'^session-view/$', session_view),
|
||||||
url(r'^redirect-view/$', redirect_view),
|
url(r'^redirect-view/$', redirect_view),
|
||||||
|
url(r'^post-view/$', post_view)
|
||||||
]
|
]
|
||||||
|
|
||||||
|
|
||||||
|
@ -181,6 +194,15 @@ class TestAPITestClient(TestCase):
|
||||||
path='/view/', data={'valid': 123, 'invalid': {'a': 123}}
|
path='/view/', data={'valid': 123, 'invalid': {'a': 123}}
|
||||||
)
|
)
|
||||||
|
|
||||||
|
def test_empty_post_uses_default_boolean_value(self):
|
||||||
|
response = self.client.post(
|
||||||
|
'/post-view/',
|
||||||
|
data=None,
|
||||||
|
content_type='application/json'
|
||||||
|
)
|
||||||
|
self.assertEqual(response.status_code, 200, response.content)
|
||||||
|
self.assertEqual(response.data, {"flag": True})
|
||||||
|
|
||||||
|
|
||||||
class TestAPIRequestFactory(TestCase):
|
class TestAPIRequestFactory(TestCase):
|
||||||
def test_csrf_exempt_by_default(self):
|
def test_csrf_exempt_by_default(self):
|
||||||
|
|
Loading…
Reference in New Issue
Block a user