From 5f024d9c7872db03c0fb35ac39ea6bb1b3a953dd Mon Sep 17 00:00:00 2001 From: Mahmoud-Barry Date: Mon, 17 Apr 2023 20:27:19 +0000 Subject: [PATCH] Add query parameter filtering to list method --- rest_framework/mixins.py | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/rest_framework/mixins.py b/rest_framework/mixins.py index 93ce07794..e725bdf94 100644 --- a/rest_framework/mixins.py +++ b/rest_framework/mixins.py @@ -41,15 +41,10 @@ class ListModelMixin: queryset = self.filter_queryset(self.get_queryset()) query_params = request.query_params - if query_params is not None: - params = {} - for key, value in query_params.items(): - try: - if self.model._meta.get_field(key): - params[key] = value - except FieldDoesNotExist: - pass - if(params): + params = {key: value for key, value in query_params.items() + if key in self.model._meta.get_fields()} + + if params: queryset = self.queryset.filter(**params) page = self.paginate_queryset(queryset)