From 5fdc4f22cff3e458fd2492d60133e47f607468f5 Mon Sep 17 00:00:00 2001 From: Dawn Pattison Date: Fri, 13 Nov 2015 10:17:09 -0500 Subject: [PATCH] Add tests to ensure ListField does not except dictionary as input. --- tests/test_fields.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/test_fields.py b/tests/test_fields.py index 104337627..b0320b2ee 100644 --- a/tests/test_fields.py +++ b/tests/test_fields.py @@ -1437,7 +1437,8 @@ class TestListField(FieldValues): ] invalid_inputs = [ ('not a list', ['Expected a list of items but got type "str".']), - ([1, 2, 'error'], ['A valid integer is required.']) + ([1, 2, 'error'], ['A valid integer is required.']), + ({'one': 'two'}, ['Expected a list of items but got type "dict".']) ] outputs = [ ([1, 2, 3], [1, 2, 3]), @@ -1454,6 +1455,14 @@ class TestListField(FieldValues): "Remove `source=` from the field declaration." ) + def test_collection_types_are_invalid_input(self): + field = serializers.ListField(child=serializers.CharField()) + input_value = ({'one': 'two'}) + + with pytest.raises(serializers.ValidationError) as exc_info: + field.to_internal_value(input_value) + assert exc_info.value.detail == [u'Expected a list of items but got type "dict".'] + class TestEmptyListField(FieldValues): """