From 677acd36f7c736837cb21738498c18565121c1da Mon Sep 17 00:00:00 2001 From: Phil Richman Date: Tue, 13 Jun 2017 15:22:10 +0100 Subject: [PATCH] Keep check for nested dict or list to catch issue with serializer using multiple fields with the same root source. --- rest_framework/serializers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index 18139e75f..eb34d55cb 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -802,7 +802,8 @@ def raise_errors_on_nested_writes(method_name, serializer, validated_data): # address = serializer.CharField('profile.address') assert not any( len(field.source_attrs) > 1 and - (field.source_attrs[0] in validated_data) + (field.source_attrs[0] in validated_data) and + isinstance(validated_data[field.source_attrs[0]], (list, dict)) for key, field in serializer.fields.items() ), ( 'The `.{method_name}()` method does not support writable dotted-source '