encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2024-11-25 19:14:01 +03:00
Code Issues Packages Projects Releases Wiki Activity

Reject PrimaryKeyRelatedField bool lookup values (#7597)

Browse Source 
* Reject PrimaryKeyRelatedField bool lookup values

* Test PrimaryKeyRelatedField bool lookup rejection

* Fix indentation in test
This commit is contained in:
Aristotelis Mikropoulos 2021-03-17 15:28:38 +02:00 committed by GitHub
parent 7b53960c3b
commit 67ebdd32cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/relations.py
View File

@ -259,6 +259,8 @@ class PrimaryKeyRelatedField(RelatedField):
data = self.pk_field.to_internal_value(data) data = self.pk_field.to_internal_value(data)
queryset = self.get_queryset() queryset = self.get_queryset()
try: try:
if isinstance(data, bool):
raise TypeError
return queryset.get(pk=data) return queryset.get(pk=data)
except ObjectDoesNotExist: except ObjectDoesNotExist:
self.fail('does_not_exist', pk_value=data) self.fail('does_not_exist', pk_value=data)

6
tests/test_relations.py
View File

@ -107,6 +107,12 @@ class TestPrimaryKeyRelatedField(APISimpleTestCase):
msg = excinfo.value.detail[0] msg = excinfo.value.detail[0]
assert msg == 'Incorrect type. Expected pk value, received BadType.' assert msg == 'Incorrect type. Expected pk value, received BadType.'
def test_pk_related_lookup_bool(self):
with pytest.raises(serializers.ValidationError) as excinfo:
self.field.to_internal_value(True)
msg = excinfo.value.detail[0]
assert msg == 'Incorrect type. Expected pk value, received bool.'
def test_pk_representation(self): def test_pk_representation(self):
representation = self.field.to_representation(self.instance) representation = self.field.to_representation(self.instance)
assert representation == self.instance.pk assert representation == self.instance.pk