encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-06-26 08:23:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check for 200 status when unknown filter requested.

Browse Source 
This changes the test from the failing checking for status 400. See
discussion here:

https://github.com/tomchristie/django-rest-framework/pull/169#issuecomment-9240480
This commit is contained in:
Ben Konrath 2012-10-09 08:22:00 +02:00
parent 1e9ece0f93
commit 692203f933
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rest_framework/tests/filterset.py
View File

@ -147,14 +147,13 @@ class IntegrationTestFiltering(TestCase):
request = factory.get('/') request = factory.get('/')
self.assertRaises(AssertionError, view, request) self.assertRaises(AssertionError, view, request)
# TODO Return 400 filter paramater requested that hasn't been configured. def test_unknown_filter(self):
def test_bad_request(self):
""" """
GET requests with filters that aren't configured should return 400. GET requests with filters that aren't configured should return 200.
""" """
view = FilterFieldsRootView.as_view() view = FilterFieldsRootView.as_view()
search_integer = 10 search_integer = 10
request = factory.get('/?integer=%s' % search_integer) request = factory.get('/?integer=%s' % search_integer)
response = view(request).render() response = view(request).render()
self.assertEquals(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEquals(response.status_code, status.HTTP_200_OK)