encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-28 17:09:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Raise deprecation warning when NullBooleanField is used

Browse Source
This commit is contained in:
Kevin Brown 2020-01-09 20:24:04 -05:00
parent ff1ebedc5f
commit 69e6030509
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rest_framework/__init__.py
View File

@ -31,3 +31,7 @@ class RemovedInDRF312Warning(DeprecationWarning):
class RemovedInDRF313Warning(PendingDeprecationWarning): class RemovedInDRF313Warning(PendingDeprecationWarning):
pass pass
class RemovedInDRF314Warning(PendingDeprecationWarning):
pass

10
rest_framework/fields.py
View File

@ -30,7 +30,7 @@ from django.utils.timezone import utc
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
from pytz.exceptions import InvalidTimeError from pytz.exceptions import InvalidTimeError
from rest_framework import ISO_8601, RemovedInDRF313Warning from rest_framework import ISO_8601, RemovedInDRF313Warning, RemovedInDRF314Warning
from rest_framework.compat import ProhibitNullCharactersValidator from rest_framework.compat import ProhibitNullCharactersValidator
from rest_framework.exceptions import ErrorDetail, ValidationError from rest_framework.exceptions import ErrorDetail, ValidationError
from rest_framework.settings import api_settings from rest_framework.settings import api_settings
@ -744,8 +744,16 @@ class NullBooleanField(BooleanField):
initial = None initial = None
def __init__(self, **kwargs): def __init__(self, **kwargs):
warnings.warn(
"The `NullBooleanField` is deprecated and will be removed starting "
"with 3.14. Instead use the `BooleanField` field and set "
"`null=True` which does the same thing.",
RemovedInDRF314Warning, stacklevel=2
)
assert 'allow_null' not in kwargs, '`allow_null` is not a valid option.' assert 'allow_null' not in kwargs, '`allow_null` is not a valid option.'
kwargs['allow_null'] = True kwargs['allow_null'] = True
super().__init__(**kwargs) super().__init__(**kwargs)