encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-27 08:29:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

improve performance for noncallble attributes

Browse Source
This commit is contained in:
Dima Kryukov 2022-05-28 02:18:04 +03:00
parent e5fb9af0ea
commit 6e26e4ba15
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rest_framework/fields.py
View File

@ -63,6 +63,9 @@ def is_simple_callable(obj):
""" """
True if the object is a callable that takes no arguments. True if the object is a callable that takes no arguments.
""" """
if not callable(obj):
return False
# Bail early since we cannot inspect built-in function signatures. # Bail early since we cannot inspect built-in function signatures.
if inspect.isbuiltin(obj): if inspect.isbuiltin(obj):
raise BuiltinSignatureError( raise BuiltinSignatureError(

4
tests/test_fields.py
View File

@ -73,6 +73,10 @@ class TestIsSimpleCallable:
assert is_simple_callable(valid_vargs_kwargs) assert is_simple_callable(valid_vargs_kwargs)
assert not is_simple_callable(invalid) assert not is_simple_callable(invalid)
@pytest.mark.parametrize('obj', (True, None, "str", b'bytes', 123, 1.23))
def test_not_callable(self, obj):
assert not is_simple_callable(obj)
def test_4602_regression(self): def test_4602_regression(self):
from django.db import models from django.db import models