encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2024-11-22 09:36:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix RemovedInDjango40Warning for middleware get_resopnse() (#7513)

Browse Source 
Fixes #7417.

Fixes all these issues seen with `tox -e py38-django31`:

```
  /Users/chainz/Documents/Projects/django-rest-framework/tests/test_request.py:208: RemovedInDjango40Warning: Passing None for the middleware get_response argument is deprecated.
    SessionMiddleware().process_request(self.wrapped_request)

tests/test_requests_client.py: 1 test with warning
tests/test_testing.py: 4 tests with warnings
tests/test_throttling.py: 1 test with warning
tests/authentication/test_authentication.py: 4 tests with warnings
tests/browsable_api/test_browsable_api.py: 4 tests with warnings
  /Users/chainz/Documents/Projects/django-rest-framework/rest_framework/authentication.py:139: RemovedInDjango40Warning: Passing None for the middleware get_response argument is deprecated.
    check = CSRFCheck()
```
This commit is contained in:
Adam Johnson 2020-10-09 10:48:03 +01:00 committed by GitHub
parent 5e23b559f8
commit 7921e9af43
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rest_framework/authentication.py
View File

@ -136,7 +136,10 @@ class SessionAuthentication(BaseAuthentication):
""" """
Enforce CSRF validation for session based authentication. Enforce CSRF validation for session based authentication.
""" """
check = CSRFCheck() def dummy_get_response(request): # pragma: no cover
return None
check = CSRFCheck(dummy_get_response)
# populates request.META['CSRF_COOKIE'], which is used in process_view() # populates request.META['CSRF_COOKIE'], which is used in process_view()
check.process_request(request) check.process_request(request)
reason = check.process_view(request, None, (), {}) reason = check.process_view(request, None, (), {})

8
tests/test_request.py
View File

@ -205,8 +205,12 @@ class TestUserSetter(TestCase):
# available to login and logout functions # available to login and logout functions
self.wrapped_request = factory.get('/') self.wrapped_request = factory.get('/')
self.request = Request(self.wrapped_request) self.request = Request(self.wrapped_request)
SessionMiddleware().process_request(self.wrapped_request)
AuthenticationMiddleware().process_request(self.wrapped_request) def dummy_get_response(request): # pragma: no cover
return None
SessionMiddleware(dummy_get_response).process_request(self.wrapped_request)
AuthenticationMiddleware(dummy_get_response).process_request(self.wrapped_request)
User.objects.create_user('ringo', 'starr@thebeatles.com', 'yellow') User.objects.create_user('ringo', 'starr@thebeatles.com', 'yellow')
self.user = authenticate(username='ringo', password='yellow') self.user = authenticate(username='ringo', password='yellow')