encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2024-11-10 19:56:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Return NotImplemented sooner for ErrorDetail equality test (#7531)

Browse Source 
The test suite raises warnings when tested against Python 3.9
`DeprecationWarning: NotImplemented should not be used in a boolean context`

Where `r` returns `NotImplemented` then this change returns `NotImplemented` first to avoid the comparison test.
This commit is contained in:
David Smith 2020-10-09 12:21:22 +01:00 committed by GitHub
parent 79daf315c4
commit 79c37d0dc3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/exceptions.py
View File

@ -73,6 +73,8 @@ class ErrorDetail(str):
def __eq__(self, other): def __eq__(self, other):
r = super().__eq__(other) r = super().__eq__(other)
if r is NotImplemented:
return NotImplemented
try: try:
return r and self.code == other.code return r and self.code == other.code
except AttributeError: except AttributeError: