encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-18 04:02:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: Use new methods in all views and use cached permissions in each view instance

Browse Source
This commit is contained in:
Ehsan200 2023-06-10 14:36:50 +03:30
parent c992532552
commit 80ce4a2cb8
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
rest_framework/views.py
View File

@ -1,6 +1,8 @@
""" """
Provides an APIView class that is the base of all views in REST framework. Provides an APIView class that is the base of all views in REST framework.
""" """
from functools import cached_property
from django.conf import settings from django.conf import settings
from django.core.exceptions import PermissionDenied from django.core.exceptions import PermissionDenied
from django.db import connections, models from django.db import connections, models
@ -277,6 +279,10 @@ class APIView(View):
""" """
return [permission() for permission in self.permission_classes] return [permission() for permission in self.permission_classes]
@cached_property
def cached_permissions(self):
return self.get_permissions()
def get_throttles(self): def get_throttles(self):
""" """
Instantiates and returns the list of throttles that this view uses. Instantiates and returns the list of throttles that this view uses.
@ -328,8 +334,8 @@ class APIView(View):
Check if the request should be permitted. Check if the request should be permitted.
Raises an appropriate exception if the request is not permitted. Raises an appropriate exception if the request is not permitted.
""" """
for permission in self.get_permissions(): for permission in self.cached_permissions:
if not permission.has_permission(request, self): if not permission.has_permission_value(request, self):
self.permission_denied( self.permission_denied(
request, request,
message=getattr(permission, 'message', None), message=getattr(permission, 'message', None),
@ -341,8 +347,8 @@ class APIView(View):
Check if the request should be permitted for a given object. Check if the request should be permitted for a given object.
Raises an appropriate exception if the request is not permitted. Raises an appropriate exception if the request is not permitted.
""" """
for permission in self.get_permissions(): for permission in self.cached_permissions:
if not permission.has_object_permission(request, self, obj): if not permission.has_object_permission_value(request, self, obj):
self.permission_denied( self.permission_denied(
request, request,
message=getattr(permission, 'message', None), message=getattr(permission, 'message', None),