encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-04 04:20:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

issue 1615: delete removed relations before adding

Browse Source 
This can prevent duplicate key errors.
This commit is contained in:
Ian Phillips 2014-06-04 13:55:12 -07:00
parent 0c91d8ed31
commit 88b602df51
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
rest_framework/serializers.py
View File

@ -1024,16 +1024,16 @@ class ModelSerializer(Serializer):
]) ])
for accessor_name, related in obj._related_data.items(): for accessor_name, related in obj._related_data.items():
if isinstance(related, RelationsList): if isinstance(related, RelationsList):
# Delete any removed objects
if related._deleted:
[self.delete_object(item) for item in related._deleted]
# Nested reverse fk relationship # Nested reverse fk relationship
for related_item in related: for related_item in related:
fk_field = related_fields[accessor_name].field.name fk_field = related_fields[accessor_name].field.name
setattr(related_item, fk_field, obj) setattr(related_item, fk_field, obj)
self.save_object(related_item) self.save_object(related_item)
# Delete any removed objects
if related._deleted:
[self.delete_object(item) for item in related._deleted]
elif isinstance(related, models.Model): elif isinstance(related, models.Model):
# Nested reverse one-one relationship # Nested reverse one-one relationship
fk_field = obj._meta.get_field_by_name(accessor_name)[0].field.name fk_field = obj._meta.get_field_by_name(accessor_name)[0].field.name