From 8a6b1a3f3c908b0bd6dae47d33ccd4d40d7d30e2 Mon Sep 17 00:00:00 2001 From: Alvaro Cavalcanti Date: Thu, 6 Sep 2018 15:27:57 -0300 Subject: [PATCH] Preventing KeyError to be raised When implementing the `MultipleFieldLookupMixin` as it was, a `KeyError` would be raised when either one of the `lookup_fields` was not present. --- docs/api-guide/generic-views.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/api-guide/generic-views.md b/docs/api-guide/generic-views.md index a0ed7bdea..eb000e2c6 100644 --- a/docs/api-guide/generic-views.md +++ b/docs/api-guide/generic-views.md @@ -328,7 +328,7 @@ For example, if you need to lookup objects based on multiple fields in the URL c queryset = self.filter_queryset(queryset) # Apply any filter backends filter = {} for field in self.lookup_fields: - if self.kwargs[field]: # Ignore empty fields. + if field in self.kwargs: # Ignore empty fields. filter[field] = self.kwargs[field] obj = get_object_or_404(queryset, **filter) # Lookup the object self.check_object_permissions(self.request, obj)