encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-02-17 03:51:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

polishing code

Browse Source 
and adding myself to auhtors file
This commit is contained in:
Ludwig Kraatz 2012-11-14 11:46:16 +01:00
parent 3a30a9b1cb
commit 8b999c6bb5
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/topics/credits.md
View File

@ -59,6 +59,7 @@ The following people have helped make REST framework great.
* Toni Michel - [tonimichel] * Toni Michel - [tonimichel]
* Ben Konrath - [benkonrath] * Ben Konrath - [benkonrath]
* Marc Aymerich - [glic3rinu] * Marc Aymerich - [glic3rinu]
* Ludwig Kraatz - [ludwigkraatz]
Many thanks to everyone who's contributed to the project. Many thanks to everyone who's contributed to the project.
@ -153,3 +154,4 @@ To contact the author directly:
[tonimichel]: https://github.com/tonimichel [tonimichel]: https://github.com/tonimichel
[benkonrath]: https://github.com/benkonrath [benkonrath]: https://github.com/benkonrath
[glic3rinu]: https://github.com/glic3rinu [glic3rinu]: https://github.com/glic3rinu
[ludwigkraatz]: https://github.com/ludwigkraatz

4
rest_framework/mixins.py
View File

@ -24,8 +24,8 @@ class CreateModelMixin(object):
return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
def get_success_headers(self,data): def get_success_headers(self,data):
if "url" in data: if 'url' in data:
return {'Location':data.get("url")} return {'Location': data.get('url')}
else: else:
return {} return {}

4
rest_framework/tests/hyperlinkedserializers.py
View File

@ -196,7 +196,7 @@ class TestCreateWithForeignKeys(TestCase):
request = factory.post('/comments/', data=data) request = factory.post('/comments/', data=data)
response = self.create_view(request).render() response = self.create_view(request).render()
self.assertEqual(response.status_code, status.HTTP_201_CREATED) self.assertEqual(response.status_code, status.HTTP_201_CREATED)
self.assertEqual(response["Location"], 'http://testserver/comments/1/') self.assertEqual(response['Location'], 'http://testserver/comments/1/')
self.assertEqual(self.post.blogpostcomment_set.count(), 1) self.assertEqual(self.post.blogpostcomment_set.count(), 1)
self.assertEqual(self.post.blogpostcomment_set.all()[0].text, 'A test comment') self.assertEqual(self.post.blogpostcomment_set.all()[0].text, 'A test comment')
@ -221,7 +221,7 @@ class TestCreateWithForeignKeysAndCustomSlug(TestCase):
request = factory.post('/photos/', data=data) request = factory.post('/photos/', data=data)
response = self.list_create_view(request).render() response = self.list_create_view(request).render()
self.assertEqual(response.status_code, status.HTTP_201_CREATED) self.assertEqual(response.status_code, status.HTTP_201_CREATED)
self.assertNotIn("Location", response, msg="Location should only be included if there is a 'url' field on the serializer") self.assertNotIn('Location', response, msg='Location should only be included if there is a "url" field on the serializer')
self.assertEqual(self.post.photo_set.count(), 1) self.assertEqual(self.post.photo_set.count(), 1)
self.assertEqual(self.post.photo_set.all()[0].description, 'A test photo') self.assertEqual(self.post.photo_set.all()[0].description, 'A test photo')