From 8de2fed4687130f03f6f1f4c401246045145a24a Mon Sep 17 00:00:00 2001 From: Ryan P Kilby Date: Mon, 17 Aug 2020 20:15:56 -0700 Subject: [PATCH] Combine the nullable boolean field test cases 'NullBooleanField' is now based on 'BooleanField(allow_null=True)' and doesn't need a test case to explicitly test its behavior. --- tests/test_fields.py | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/tests/test_fields.py b/tests/test_fields.py index b1ad1dc66..b3157fd94 100644 --- a/tests/test_fields.py +++ b/tests/test_fields.py @@ -673,9 +673,9 @@ class TestBooleanField(FieldValues): assert exc_info.value.detail == expected -class TestNullBooleanField(TestBooleanField): +class TestNullableBooleanField(TestBooleanField): """ - Valid and invalid values for `NullBooleanField`. + Valid and invalid values for `BooleanField(allow_null=True)`. """ valid_inputs = { 'true': True, @@ -697,17 +697,7 @@ class TestNullBooleanField(TestBooleanField): None: None, 'other': True } - field = serializers.NullBooleanField() - - -class TestNullableBooleanField(TestNullBooleanField): - """ - Valid and invalid values for `BooleanField` when `allow_null=True`. - """ - - @property - def field(self): - return serializers.BooleanField(allow_null=True) + field = serializers.BooleanField(allow_null=True) # String types...