From 6d95da7b2d26f3927527b24a7a63704d60c7376e Mon Sep 17 00:00:00 2001 From: Xavier Ordoquy Date: Thu, 21 Jan 2016 16:48:32 +0100 Subject: [PATCH 1/2] Improve the `get_queryset` overriding test readability. --- tests/test_relations.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_relations.py b/tests/test_relations.py index 87dc28451..da571717a 100644 --- a/tests/test_relations.py +++ b/tests/test_relations.py @@ -177,9 +177,11 @@ class TestSlugRelatedField(APISimpleTestCase): assert representation == self.instance.name def test_no_queryset_init(self): + qs = self.queryset + class NoQuerySetSlugRelatedField(serializers.SlugRelatedField): - def get_queryset(this): - return self.queryset + def get_queryset(self): + return qs field = NoQuerySetSlugRelatedField(slug_field='name') field.to_internal_value(self.instance.name) From 5068ecf64bc2e4da94fa666e24f2bf777117c1e9 Mon Sep 17 00:00:00 2001 From: Xavier Ordoquy Date: Thu, 21 Jan 2016 16:50:07 +0100 Subject: [PATCH 2/2] Rename the `get_queryset` overriding test. --- tests/test_relations.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_relations.py b/tests/test_relations.py index da571717a..240878394 100644 --- a/tests/test_relations.py +++ b/tests/test_relations.py @@ -176,7 +176,7 @@ class TestSlugRelatedField(APISimpleTestCase): representation = self.field.to_representation(self.instance) assert representation == self.instance.name - def test_no_queryset_init(self): + def test_overriding_get_queryset(self): qs = self.queryset class NoQuerySetSlugRelatedField(serializers.SlugRelatedField):