From 956502757a3dd6bb323b0c34edc08f8e57b2f9e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Corbin?= Date: Mon, 12 Aug 2019 18:49:00 +0200 Subject: [PATCH] Put declaration in test class --- tests/test_filters.py | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/tests/test_filters.py b/tests/test_filters.py index eb18b8e25..4add741ed 100644 --- a/tests/test_filters.py +++ b/tests/test_filters.py @@ -689,21 +689,18 @@ class SensitiveOrderingFilterTests(TestCase): {'id': 3, username_field: 'userC'}, # PassA ] - -if postgres_fields: - class JSONOrderingFilterModel(models.Model): - data = postgres_fields.JSONField() - - - class JSONOrderingFilterSerializer(serializers.ModelSerializer): - class Meta: - model = JSONOrderingFilterModel - fields = '__all__' - - -@pytest.mark.skipif(postgres_fields is None, reason='not a postgresql database') + +@pytest.mark.skipif('not postgres_fields') class JSONOrderingFilterTests(TestCase): def test_order_by_json_field(self): + class JSONOrderingFilterModel(models.Model): + data = postgres_fields.JSONField() + + + class JSONOrderingFilterSerializer(serializers.ModelSerializer): + class Meta: + model = JSONOrderingFilterModel + fields = '__all__' class OrderingListView(generics.ListAPIView): queryset = JSONOrderingFilterModel.objects.all()