encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-28 17:09:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

move the OrderedDict call up to the local variable

Browse Source
This commit is contained in:
Dhaval Mehta 2020-01-28 01:53:58 +05:30
parent a5eb316ec4
commit 989e431be4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rest_framework/schemas/openapi.py
View File

@ -212,7 +212,7 @@ class AutoSchema(ViewInspector):
return paginator.get_schema_operation_parameters(view)
def _map_choicefield(self, field):
choices = list(field.choices)
choices = list(OrderedDict.fromkeys(field.choices)) # preserve order and remove duplicates
if all(isinstance(choice, bool) for choice in choices):
type = 'boolean'
elif all(isinstance(choice, int) for choice in choices):
@ -228,7 +228,7 @@ class AutoSchema(ViewInspector):
mapping = {
# The value of `enum` keyword MUST be an array and SHOULD be unique.
# Ref: https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-5.20
'enum': list(OrderedDict.fromkeys(choices)) # preserve order and remove duplicates
'enum': choices
}
# If We figured out `type` then and only then we should set it. It must be string or an array.