mirror of
https://github.com/encode/django-rest-framework.git
synced 2024-11-10 19:56:59 +03:00
Make api_view respect standard wrapper assignments (#8291)
This commit is contained in:
parent
d0bb4d877f
commit
9c97946531
|
@ -7,6 +7,7 @@ based views, as well as the `@action` decorator, which is used to annotate
|
|||
methods on viewsets that should be included by routers.
|
||||
"""
|
||||
import types
|
||||
from functools import update_wrapper
|
||||
|
||||
from django.forms.utils import pretty_name
|
||||
|
||||
|
@ -22,18 +23,8 @@ def api_view(http_method_names=None):
|
|||
|
||||
def decorator(func):
|
||||
|
||||
WrappedAPIView = type(
|
||||
'WrappedAPIView',
|
||||
(APIView,),
|
||||
{'__doc__': func.__doc__}
|
||||
)
|
||||
|
||||
# Note, the above allows us to set the docstring.
|
||||
# It is the equivalent of:
|
||||
#
|
||||
# class WrappedAPIView(APIView):
|
||||
# pass
|
||||
# WrappedAPIView.__doc__ = func.doc <--- Not possible to do this
|
||||
class WrappedAPIView(APIView):
|
||||
pass
|
||||
|
||||
# api_view applied without (method_names)
|
||||
assert not(isinstance(http_method_names, types.FunctionType)), \
|
||||
|
@ -52,9 +43,6 @@ def api_view(http_method_names=None):
|
|||
for method in http_method_names:
|
||||
setattr(WrappedAPIView, method.lower(), handler)
|
||||
|
||||
WrappedAPIView.__name__ = func.__name__
|
||||
WrappedAPIView.__module__ = func.__module__
|
||||
|
||||
WrappedAPIView.renderer_classes = getattr(func, 'renderer_classes',
|
||||
APIView.renderer_classes)
|
||||
|
||||
|
@ -73,7 +61,7 @@ def api_view(http_method_names=None):
|
|||
WrappedAPIView.schema = getattr(func, 'schema',
|
||||
APIView.schema)
|
||||
|
||||
return WrappedAPIView.as_view()
|
||||
return update_wrapper(WrappedAPIView.as_view(), func)
|
||||
|
||||
return decorator
|
||||
|
||||
|
|
|
@ -162,6 +162,16 @@ class DecoratorTestCase(TestCase):
|
|||
|
||||
assert isinstance(view.cls.schema, CustomSchema)
|
||||
|
||||
def test_wrapper_assignments(self):
|
||||
@api_view(["GET"])
|
||||
def test_view(request):
|
||||
"""example docstring"""
|
||||
pass
|
||||
|
||||
assert test_view.__name__ == "test_view"
|
||||
assert test_view.__doc__ == "example docstring"
|
||||
assert test_view.__qualname__ == "DecoratorTestCase.test_wrapper_assignments.<locals>.test_view"
|
||||
|
||||
|
||||
class ActionDecoratorTestCase(TestCase):
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user