mirror of
https://github.com/encode/django-rest-framework.git
synced 2025-07-29 17:39:48 +03:00
Add failing tests for ordering filter with model property
This commit is contained in:
parent
04e0c2b9ab
commit
a163c51238
|
@ -424,6 +424,10 @@ class OrderingFilterModel(models.Model):
|
|||
title = models.CharField(max_length=20, verbose_name='verbose title')
|
||||
text = models.CharField(max_length=100)
|
||||
|
||||
@property
|
||||
def description(self):
|
||||
return self.title + ": " + self.text
|
||||
|
||||
|
||||
class OrderingFilterRelatedModel(models.Model):
|
||||
related_object = models.ForeignKey(OrderingFilterModel, related_name="relateds", on_delete=models.CASCADE)
|
||||
|
@ -436,6 +440,17 @@ class OrderingFilterSerializer(serializers.ModelSerializer):
|
|||
fields = '__all__'
|
||||
|
||||
|
||||
class OrderingFilterSerializerWithModelProperty(serializers.ModelSerializer):
|
||||
class Meta:
|
||||
model = OrderingFilterModel
|
||||
fields = (
|
||||
"id",
|
||||
"title",
|
||||
"text",
|
||||
"description"
|
||||
)
|
||||
|
||||
|
||||
class OrderingDottedRelatedSerializer(serializers.ModelSerializer):
|
||||
related_text = serializers.CharField(source='related_object.text')
|
||||
related_title = serializers.CharField(source='related_object.title')
|
||||
|
@ -551,6 +566,42 @@ class OrderingFilterTests(TestCase):
|
|||
{'id': 1, 'title': 'zyx', 'text': 'abc'},
|
||||
]
|
||||
|
||||
def test_ordering_without_ordering_fields(self):
|
||||
class OrderingListView(generics.ListAPIView):
|
||||
queryset = OrderingFilterModel.objects.all()
|
||||
serializer_class = OrderingFilterSerializerWithModelProperty
|
||||
filter_backends = (filters.OrderingFilter,)
|
||||
ordering = ('title',)
|
||||
|
||||
view = OrderingListView.as_view()
|
||||
|
||||
# Model field ordering works fine.
|
||||
request = factory.get('/', {'ordering': 'text'})
|
||||
response = view(request)
|
||||
assert response.data == [
|
||||
{'id': 1, 'title': 'zyx', 'text': 'abc', 'description': 'zyx: abc'},
|
||||
{'id': 2, 'title': 'yxw', 'text': 'bcd', 'description': 'yxw: bcd'},
|
||||
{'id': 3, 'title': 'xwv', 'text': 'cde', 'description': 'xwv: cde'},
|
||||
]
|
||||
|
||||
# `incorrectfield` ordering works fine.
|
||||
request = factory.get('/', {'ordering': 'foobar'})
|
||||
response = view(request)
|
||||
assert response.data == [
|
||||
{'id': 3, 'title': 'xwv', 'text': 'cde', 'description': 'xwv: cde'},
|
||||
{'id': 2, 'title': 'yxw', 'text': 'bcd', 'description': 'yxw: bcd'},
|
||||
{'id': 1, 'title': 'zyx', 'text': 'abc', 'description': 'zyx: abc'},
|
||||
]
|
||||
|
||||
# `description` is a Model property, which should be ignored.
|
||||
request = factory.get('/', {'ordering': 'description'})
|
||||
response = view(request)
|
||||
assert response.data == [
|
||||
{'id': 3, 'title': 'xwv', 'text': 'cde', 'description': 'xwv: cde'},
|
||||
{'id': 2, 'title': 'yxw', 'text': 'bcd', 'description': 'yxw: bcd'},
|
||||
{'id': 1, 'title': 'zyx', 'text': 'abc', 'description': 'zyx: abc'},
|
||||
]
|
||||
|
||||
def test_default_ordering(self):
|
||||
class OrderingListView(generics.ListAPIView):
|
||||
queryset = OrderingFilterModel.objects.all()
|
||||
|
|
Loading…
Reference in New Issue
Block a user