encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-01-24 00:04:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix missing validated_data in raise_errors_on_nested_writes (#2221)

Browse Source
This commit is contained in:
Xavier Ordoquy 2014-12-07 12:12:40 +01:00
parent 71c49fea8a
commit a257b04928
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rest_framework/serializers.py
View File

@ -561,7 +561,7 @@ class ListSerializer(BaseSerializer):
# ModelSerializer & HyperlinkedModelSerializer # ModelSerializer & HyperlinkedModelSerializer
# -------------------------------------------- # --------------------------------------------
def raise_errors_on_nested_writes(method_name, serializer): def raise_errors_on_nested_writes(method_name, serializer, validated_data):
""" """
Give explicit errors when users attempt to pass writable nested data. Give explicit errors when users attempt to pass writable nested data.
@ -586,7 +586,7 @@ def raise_errors_on_nested_writes(method_name, serializer):
# ... # ...
# profile = ProfileSerializer() # profile = ProfileSerializer()
assert not any( assert not any(
isinstance(field, BaseSerializer) and (key in validated_attrs) isinstance(field, BaseSerializer) and (key in validated_data)
for key, field in serializer.fields.items() for key, field in serializer.fields.items()
), ( ), (
'The `.{method_name}()` method does not support writable nested' 'The `.{method_name}()` method does not support writable nested'
@ -605,7 +605,7 @@ def raise_errors_on_nested_writes(method_name, serializer):
# ... # ...
# address = serializer.CharField('profile.address') # address = serializer.CharField('profile.address')
assert not any( assert not any(
'.' in field.source and (key in validated_attrs) '.' in field.source and (key in validated_data)
for key, field in serializer.fields.items() for key, field in serializer.fields.items()
), ( ), (
'The `.{method_name}()` method does not support writable dotted-source ' 'The `.{method_name}()` method does not support writable dotted-source '
@ -682,7 +682,7 @@ class ModelSerializer(Serializer):
If you want to support writable nested relationships you'll need If you want to support writable nested relationships you'll need
to write an explicit `.create()` method. to write an explicit `.create()` method.
""" """
raise_errors_on_nested_writes('create', self) raise_errors_on_nested_writes('create', self, validated_data)
ModelClass = self.Meta.model ModelClass = self.Meta.model
@ -722,7 +722,7 @@ class ModelSerializer(Serializer):
return instance return instance
def update(self, instance, validated_data): def update(self, instance, validated_data):
raise_errors_on_nested_writes('update', self) raise_errors_on_nested_writes('update', self, validated_data)
for attr, value in validated_data.items(): for attr, value in validated_data.items():
setattr(instance, attr, value) setattr(instance, attr, value)