encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-04 12:30:11 +03:00
Code Issues Packages Projects Releases Wiki Activity

Move get_filter_fields to descriptor

Browse Source
This commit is contained in:
Carlton Gibson 2017-08-23 11:07:56 +02:00
parent 1d6562e6ad
commit aad9289ae9
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
rest_framework/schemas.py
View File

@ -280,9 +280,9 @@ class APIViewSchemaDescriptor(object):
fields = self.get_path_fields(path, method) fields = self.get_path_fields(path, method)
fields += self.get_serializer_fields(path, method) fields += self.get_serializer_fields(path, method)
fields += self.get_pagination_fields(path, method) fields += self.get_pagination_fields(path, method)
fields += self.get_filter_fields(path, method)
# TEMP: now we proxy back to the generator # TEMP: now we proxy back to the generator
fields += generator.get_filter_fields(path, method, view)
if fields and any([field.location in ('form', 'body') for field in fields]): if fields and any([field.location in ('form', 'body') for field in fields]):
encoding = generator.get_encoding(path, method, view) encoding = generator.get_encoding(path, method, view)
@ -442,6 +442,19 @@ class APIViewSchemaDescriptor(object):
paginator = view.pagination_class() paginator = view.pagination_class()
return paginator.get_schema_fields(view) return paginator.get_schema_fields(view)
def get_filter_fields(self, path, method):
view = self.view
if not is_list_view(path, method, view):
return []
if not getattr(view, 'filter_backends', None):
return []
fields = []
for filter_backend in view.filter_backends:
fields += filter_backend().get_schema_fields(view)
return fields
# TODO: Where should this live? # TODO: Where should this live?
# - We import APIView here. So we can't import the descriptor into `views` # - We import APIView here. So we can't import the descriptor into `views`
@ -650,18 +663,6 @@ class SchemaGenerator(object):
return None return None
def get_filter_fields(self, path, method, view):
if not is_list_view(path, method, view):
return []
if not getattr(view, 'filter_backends', None):
return []
fields = []
for filter_backend in view.filter_backends:
fields += filter_backend().get_schema_fields(view)
return fields
# Method for generating the link layout.... # Method for generating the link layout....
def get_keys(self, subpath, method, view): def get_keys(self, subpath, method, view):