encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-03 12:00:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Warn if BrowsableAPIRenderer.get_filter_form fails

Browse Source 
I spent a bit of time trying to figure out why the filter form wasn't showing up for one custom class, which turned out to be because the paginator uses a hard-coded `results` key and the viewset method in question was using `records`. I fixed that in my code but a warning message for the exception would have made that much easier to find.
This commit is contained in:
Chris Adams 2018-01-12 11:31:52 -05:00 committed by GitHub
parent b2ec681d8d
commit ad825341f8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rest_framework/renderers.py
View File

@ -10,6 +10,7 @@ from __future__ import unicode_literals
import base64 import base64
from collections import OrderedDict from collections import OrderedDict
from warnings import warn
from django import forms from django import forms
from django.conf import settings from django.conf import settings
@ -623,7 +624,8 @@ class BrowsableAPIRenderer(BaseRenderer):
elif paginator is not None and data is not None: elif paginator is not None and data is not None:
try: try:
paginator.get_results(data) paginator.get_results(data)
except (TypeError, KeyError): except (TypeError, KeyError) as exc:
warn('get_filter_form() aborting because pagination failed: %s' % exc)
return return
elif not isinstance(data, list): elif not isinstance(data, list):
return return