Merge pull request #2448 from tomchristie/uuid-field

Added UUIDField.
This commit is contained in:
Tom Christie 2015-01-23 15:43:21 +00:00
commit b07d931261
5 changed files with 53 additions and 2 deletions

View File

@ -182,6 +182,12 @@ Corresponds to `django.db.models.fields.URLField`. Uses Django's `django.core.v
**Signature:** `URLField(max_length=200, min_length=None, allow_blank=False)` **Signature:** `URLField(max_length=200, min_length=None, allow_blank=False)`
## UUIDField
A field that ensures the input is a valid UUID string. The `to_internal_value` method will return a `uuid.UUID` instance. On output the field will return a string in the canonical hyphenated format, for example:
"de305d54-75b4-431b-adb2-eb6b9e546013"
--- ---
# Numeric fields # Numeric fields
@ -320,7 +326,7 @@ Both the `allow_blank` and `allow_null` are valid options on `ChoiceField`, alth
## MultipleChoiceField ## MultipleChoiceField
A field that can accept a set of zero, one or many values, chosen from a limited set of choices. Takes a single mandatory argument. `to_internal_representation` returns a `set` containing the selected values. A field that can accept a set of zero, one or many values, chosen from a limited set of choices. Takes a single mandatory argument. `to_internal_value` returns a `set` containing the selected values.
**Signature:** `MultipleChoiceField(choices)` **Signature:** `MultipleChoiceField(choices)`

View File

@ -23,6 +23,7 @@ import datetime
import decimal import decimal
import inspect import inspect
import re import re
import uuid
class empty: class empty:
@ -632,6 +633,23 @@ class URLField(CharField):
self.validators.append(validator) self.validators.append(validator)
class UUIDField(Field):
default_error_messages = {
'invalid': _('"{value}" is not a valid UUID.'),
}
def to_internal_value(self, data):
if not isinstance(data, uuid.UUID):
try:
return uuid.UUID(data)
except (ValueError, TypeError):
self.fail('invalid', value=data)
return data
def to_representation(self, value):
return str(value)
# Number types... # Number types...
class IntegerField(Field): class IntegerField(Field):

View File

@ -702,6 +702,7 @@ class ModelSerializer(Serializer):
you need you should either declare the extra/differing fields explicitly on you need you should either declare the extra/differing fields explicitly on
the serializer class, or simply use a `Serializer` class. the serializer class, or simply use a `Serializer` class.
""" """
_field_mapping = ClassLookupDict({ _field_mapping = ClassLookupDict({
models.AutoField: IntegerField, models.AutoField: IntegerField,
models.BigIntegerField: IntegerField, models.BigIntegerField: IntegerField,
@ -724,7 +725,8 @@ class ModelSerializer(Serializer):
models.SmallIntegerField: IntegerField, models.SmallIntegerField: IntegerField,
models.TextField: CharField, models.TextField: CharField,
models.TimeField: TimeField, models.TimeField: TimeField,
models.URLField: URLField, models.URLField: URLField
# Note: Some version-specific mappings also defined below.
}) })
_related_class = PrimaryKeyRelatedField _related_class = PrimaryKeyRelatedField
@ -1132,6 +1134,10 @@ class ModelSerializer(Serializer):
return NestedSerializer return NestedSerializer
if hasattr(models, 'UUIDField'):
ModelSerializer._field_mapping[models.UUIDField] = UUIDField
class HyperlinkedModelSerializer(ModelSerializer): class HyperlinkedModelSerializer(ModelSerializer):
""" """
A type of `ModelSerializer` that uses hyperlinked relationships instead A type of `ModelSerializer` that uses hyperlinked relationships instead

View File

@ -38,6 +38,9 @@ class ClassLookupDict(object):
return self.mapping[cls] return self.mapping[cls]
raise KeyError('Class %s not found in lookup.', cls.__name__) raise KeyError('Class %s not found in lookup.', cls.__name__)
def __setitem__(self, key, value):
self.mapping[key] = value
def needs_label(model_field, field_name): def needs_label(model_field, field_name):
""" """

View File

@ -4,6 +4,7 @@ from rest_framework import serializers
import datetime import datetime
import django import django
import pytest import pytest
import uuid
# Tests for field keyword arguments and core functionality. # Tests for field keyword arguments and core functionality.
@ -467,6 +468,23 @@ class TestURLField(FieldValues):
field = serializers.URLField() field = serializers.URLField()
class TestUUIDField(FieldValues):
"""
Valid and invalid values for `UUIDField`.
"""
valid_inputs = {
'825d7aeb-05a9-45b5-a5b7-05df87923cda': uuid.UUID('825d7aeb-05a9-45b5-a5b7-05df87923cda'),
'825d7aeb05a945b5a5b705df87923cda': uuid.UUID('825d7aeb-05a9-45b5-a5b7-05df87923cda')
}
invalid_inputs = {
'825d7aeb-05a9-45b5-a5b7': ['"825d7aeb-05a9-45b5-a5b7" is not a valid UUID.']
}
outputs = {
uuid.UUID('825d7aeb-05a9-45b5-a5b7-05df87923cda'): '825d7aeb-05a9-45b5-a5b7-05df87923cda'
}
field = serializers.UUIDField()
# Number types... # Number types...
class TestIntegerField(FieldValues): class TestIntegerField(FieldValues):