This commit is contained in:
Mattia Procopio 2014-09-11 14:02:51 +00:00
commit b39dde8b05
2 changed files with 2 additions and 1 deletions

View File

@ -454,7 +454,7 @@ class BooleanField(WritableField):
return True return True
if value in ('false', 'f', 'False', '0'): if value in ('false', 'f', 'False', '0'):
return False return False
return bool(value) raise ValidationError(self.error_messages['invalid'] % _(value))
class CharField(WritableField): class CharField(WritableField):

View File

@ -1002,6 +1002,7 @@ class BooleanField(TestCase):
bool_field = serializers.BooleanField(required=True) bool_field = serializers.BooleanField(required=True)
self.assertFalse(BooleanRequiredSerializer(data={}).is_valid()) self.assertFalse(BooleanRequiredSerializer(data={}).is_valid())
self.assertFalse(BooleanRequiredSerializer(data={'bool_field': 'I\'m a string!'}).is_valid())
class ModelCharField(TestCase): class ModelCharField(TestCase):