encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-24 14:14:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improvements according to review comments.

Browse Source
This commit is contained in:
Oleg Nykolyn 2018-08-06 14:32:10 +03:00
parent 98a12e2d42
commit b88e0dcbe5
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rest_framework/serializers.py
View File

@ -937,15 +937,14 @@ class ModelSerializer(Serializer):
many_to_many[field_name] = validated_data.pop(field_name)
try:
instance = ModelClass(**validated_data)
instance.save(force_insert=True)
instance = ModelClass._default_manager.create(**validated_data)
except TypeError:
tb = traceback.format_exc()
msg = (
'Got a `TypeError` when calling `%s()`. '
'Got a `TypeError` when calling `%s._default_manager.create()`. '
'This may be because you have a writable field on the '
'serializer class that is not a valid argument to '
'`%s()`. You may need to make the field '
'`%s._default_manager.create()`. You may need to make the field '
'read-only, or override the %s.create() method to handle '
'this correctly.\nOriginal exception was:\n %s' %
(

2
tests/test_model_serializer.py
View File

@ -133,7 +133,7 @@ class TestModelSerializer(TestCase):
})
serializer.is_valid()
msginitial = 'Got a `TypeError` when calling `OneFieldModel()`.'
msginitial = 'Got a `TypeError` when calling `OneFieldModel._default_manager.create()`.'
with self.assertRaisesMessage(TypeError, msginitial):
serializer.save()