encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-06 21:40:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

converted validators test to pytest style

Browse Source
This commit is contained in:
Asif Saifuddin Auvi 2016-11-23 19:32:11 +06:00
parent 3bc4138fe7
commit bb31469027
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/test_validators.py
View File

@ -69,7 +69,9 @@ class TestUniquenessValidation(TestCase):
expected = dedent(""" expected = dedent("""
UniquenessSerializer(): UniquenessSerializer():
id = IntegerField(label='ID', read_only=True) id = IntegerField(label='ID', read_only=True)
username = CharField(max_length=100, validators=[<UniqueValidator(queryset=UniquenessModel.objects.all())>]) username = CharField(
max_length=100,
validators=[<UniqueValidator(queryset=UniquenessModel.objects.all())>])
""") """)
assert repr(serializer) == expected assert repr(serializer) == expected
@ -94,23 +96,20 @@ class TestUniquenessValidation(TestCase):
def test_doesnt_pollute_model(self): def test_doesnt_pollute_model(self):
instance = AnotherUniquenessModel.objects.create(code='100') instance = AnotherUniquenessModel.objects.create(code='100')
serializer = AnotherUniquenessSerializer(instance) serializer = AnotherUniquenessSerializer(instance)
self.assertEqual( assert AnotherUniquenessModel._meta.get_field('code').validators == []
AnotherUniquenessModel._meta.get_field('code').validators, [])
# Accessing data shouldn't effect validators on the model # Accessing data shouldn't effect validators on the model
serializer.data serializer.data
self.assertEqual( assert AnotherUniquenessModel._meta.get_field('code').validators == []
AnotherUniquenessModel._meta.get_field('code').validators, [])
def test_related_model_is_unique(self): def test_related_model_is_unique(self):
data = {'username': 'Existing', 'email': 'new-email@example.com'} data = {'username': 'Existing', 'email': 'new-email@example.com'}
rs = RelatedModelSerializer(data=data) rs = RelatedModelSerializer(data=data)
self.assertFalse(rs.is_valid()) assert not rs.is_valid()
self.assertEqual(rs.errors, assert rs.errors == {'username': ['This field must be unique.']}
{'username': ['This field must be unique.']})
data = {'username': 'new-username', 'email': 'new-email@example.com'} data = {'username': 'new-username', 'email': 'new-email@example.com'}
rs = RelatedModelSerializer(data=data) rs = RelatedModelSerializer(data=data)
self.assertTrue(rs.is_valid()) assert rs.is_valid()
def test_value_error_treated_as_not_unique(self): def test_value_error_treated_as_not_unique(self):
serializer = UniquenessIntegerSerializer(data={'integer': 'abc'}) serializer = UniquenessIntegerSerializer(data={'integer': 'abc'})