improved code

just minor renaming / cleaning up
This commit is contained in:
Ludwig Kraatz 2012-12-01 14:02:49 +01:00
parent 448932c659
commit bd07cd8d20

View File

@ -110,7 +110,6 @@ class BaseSerializer(Field):
self._errors = None self._errors = None
self._headers = {} self._headers = {}
##### #####
# Methods to determine which fields to use when (de)serializing objects. # Methods to determine which fields to use when (de)serializing objects.
@ -327,16 +326,16 @@ class BaseSerializer(Field):
return self.object return self.object
def generate_header(self): def _generate_headers(self):
return {} return {}
@property @property
def headers(self): def headers(self):
#self._headers.update(self.generate_header()) ret = self._generate_headers()
return self._headers ret.update(self._headers)
return ret
def set_location_header(self): def set_location_header(self):
self._headers['Location'] = 'x'
if hasattr(self.object, 'get_absolute_url'): if hasattr(self.object, 'get_absolute_url'):
self._headers['Location'] = self.object.get_absolute_url() self._headers['Location'] = self.object.get_absolute_url()
return True return True
@ -576,10 +575,3 @@ class HyperlinkedModelSerializer(ModelSerializer):
if to_many: if to_many:
return ManyHyperlinkedRelatedField(**kwargs) return ManyHyperlinkedRelatedField(**kwargs)
return HyperlinkedRelatedField(**kwargs) return HyperlinkedRelatedField(**kwargs)
def set_location_header(self):
if not super(HyperlinkedModelSerializer, self).set_location_header():
self._headers['Location'] = self.data['url']
return True
return True