From bdcecf48e3c0bd592d50b6b6fac6353a41c3cbfd Mon Sep 17 00:00:00 2001 From: Mjumbe Wawatu Ukweli Date: Mon, 11 Mar 2013 16:01:14 -0400 Subject: [PATCH] Simplify inherited child check to not use isinstance --- rest_framework/serializers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index 1b044c5fa..cd2bb8f1f 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -458,7 +458,7 @@ class ModelSerializer(Serializer): pk_field = opts.pk # If model is a child via multitable inheritance, use parent's pk - while isinstance(pk_field, models.OneToOneField) and pk_field.rel.parent_link: + while pk_field.rel and pk_field.rel.parent_link: pk_field = pk_field.rel.to._meta.pk fields = [pk_field]