encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-03-25 04:14:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve avoid validation test: #900

Browse Source
This commit is contained in:
David Medina 2013-05-30 09:07:30 +02:00
parent d11b55648c
commit c176af35e5
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
rest_framework/tests/test_validation.py
View File

@ -65,14 +65,23 @@ class TestPreSaveValidationExclusions(TestCase):
self.assertEqual(serializer.is_valid(), False) self.assertEqual(serializer.is_valid(), False)
class FieldValidationSerializer(serializers.Serializer): class ValidationSerializer(serializers.Serializer):
foo = serializers.CharField() foo = serializers.CharField()
def validate_foo(self, attrs, source): def validate_foo(self, attrs, source):
raise StandardError("validate_foo was called") raise serializers.ValidationError("foo invalid")
def validate(self, attrs):
raise serializers.ValidationError("serializer invalid")
class TestFieldValidationWithInvalidData(TestCase): class TestAvoidValidation(TestCase):
def test_validate_foo_was_not_called(self): """
serializer = FieldValidationSerializer(data='invalid data') If serializer was initialized with invalid data (None or non dict-like), it
should avoid validation layer (validate_<field> and validate methods)
"""
def test_serializer_errors_has_only_invalid_data_error(self):
serializer = ValidationSerializer(data='invalid data')
self.assertFalse(serializer.is_valid()) self.assertFalse(serializer.is_valid())
self.assertDictEqual(serializer.errors,
{'non_field_errors': ['Invalid data']})