mirror of
				https://github.com/encode/django-rest-framework.git
				synced 2025-11-04 18:08:03 +03:00 
			
		
		
		
	Processed review comments.
No type checking in .restore_fields() Added missing BytesIO import.
This commit is contained in:
		
							parent
							
								
									8cdbc0a33a
								
							
						
					
					
						commit
						c35b9eb065
					
				| 
						 | 
				
			
			@ -3,6 +3,8 @@ import datetime
 | 
			
		|||
import inspect
 | 
			
		||||
import warnings
 | 
			
		||||
 | 
			
		||||
from io import BytesIO
 | 
			
		||||
 | 
			
		||||
from django.core import validators
 | 
			
		||||
from django.core.exceptions import ObjectDoesNotExist, ValidationError
 | 
			
		||||
from django.core.urlresolvers import resolve, get_script_prefix
 | 
			
		||||
| 
						 | 
				
			
			@ -31,6 +33,7 @@ class Field(object):
 | 
			
		|||
    creation_counter = 0
 | 
			
		||||
    empty = ''
 | 
			
		||||
    type_name = None
 | 
			
		||||
    _use_files = None
 | 
			
		||||
 | 
			
		||||
    def __init__(self, source=None):
 | 
			
		||||
        self.parent = None
 | 
			
		||||
| 
						 | 
				
			
			@ -51,7 +54,7 @@ class Field(object):
 | 
			
		|||
        self.root = parent.root or parent
 | 
			
		||||
        self.context = self.root.context
 | 
			
		||||
 | 
			
		||||
    def field_from_native(self, data, field_name, into):
 | 
			
		||||
    def field_from_native(self, data, files, field_name, into):
 | 
			
		||||
        """
 | 
			
		||||
        Given a dictionary and a field name, updates the dictionary `into`,
 | 
			
		||||
        with the field and it's deserialized value.
 | 
			
		||||
| 
						 | 
				
			
			@ -166,7 +169,7 @@ class WritableField(Field):
 | 
			
		|||
        if errors:
 | 
			
		||||
            raise ValidationError(errors)
 | 
			
		||||
 | 
			
		||||
    def field_from_native(self, data, field_name, into):
 | 
			
		||||
    def field_from_native(self, data, files, field_name, into):
 | 
			
		||||
        """
 | 
			
		||||
        Given a dictionary and a field name, updates the dictionary `into`,
 | 
			
		||||
        with the field and it's deserialized value.
 | 
			
		||||
| 
						 | 
				
			
			@ -175,6 +178,9 @@ class WritableField(Field):
 | 
			
		|||
            return
 | 
			
		||||
 | 
			
		||||
        try:
 | 
			
		||||
            if self._use_files:
 | 
			
		||||
                native = files[field_name]
 | 
			
		||||
            else:
 | 
			
		||||
                native = data[field_name]
 | 
			
		||||
        except KeyError:
 | 
			
		||||
            if self.default is not None:
 | 
			
		||||
| 
						 | 
				
			
			@ -323,7 +329,7 @@ class RelatedField(WritableField):
 | 
			
		|||
        value = getattr(obj, self.source or field_name)
 | 
			
		||||
        return self.to_native(value)
 | 
			
		||||
 | 
			
		||||
    def field_from_native(self, data, field_name, into):
 | 
			
		||||
    def field_from_native(self, data, files, field_name, into):
 | 
			
		||||
        if self.read_only:
 | 
			
		||||
            return
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -341,7 +347,7 @@ class ManyRelatedMixin(object):
 | 
			
		|||
        value = getattr(obj, self.source or field_name)
 | 
			
		||||
        return [self.to_native(item) for item in value.all()]
 | 
			
		||||
 | 
			
		||||
    def field_from_native(self, data, field_name, into):
 | 
			
		||||
    def field_from_native(self, data, files, field_name, into):
 | 
			
		||||
        if self.read_only:
 | 
			
		||||
            return
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -907,8 +913,10 @@ class FloatField(WritableField):
 | 
			
		|||
 | 
			
		||||
 | 
			
		||||
class FileField(WritableField):
 | 
			
		||||
    _use_files = True
 | 
			
		||||
    type_name = 'FileField'
 | 
			
		||||
    widget = widgets.FileInput
 | 
			
		||||
 | 
			
		||||
    default_error_messages = {
 | 
			
		||||
        'invalid': _("No file was submitted. Check the encoding type on the form."),
 | 
			
		||||
        'missing': _("No file was submitted."),
 | 
			
		||||
| 
						 | 
				
			
			@ -951,6 +959,8 @@ class FileField(WritableField):
 | 
			
		|||
 | 
			
		||||
 | 
			
		||||
class ImageField(FileField):
 | 
			
		||||
    _use_files = True
 | 
			
		||||
 | 
			
		||||
    default_error_messages = {
 | 
			
		||||
        'invalid_image': _("Upload a valid image. The file you uploaded was either not an image or a corrupted image."),
 | 
			
		||||
    }
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -198,10 +198,7 @@ class BaseSerializer(Field):
 | 
			
		|||
        reverted_data = {}
 | 
			
		||||
        for field_name, field in fields.items():
 | 
			
		||||
            try:
 | 
			
		||||
                if isinstance(field, (FileField, ImageField)):
 | 
			
		||||
                    field.field_from_native(files, field_name, reverted_data)
 | 
			
		||||
                else:
 | 
			
		||||
                    field.field_from_native(data, field_name, reverted_data)
 | 
			
		||||
                field.field_from_native(data, files, field_name, reverted_data)
 | 
			
		||||
            except ValidationError as err:
 | 
			
		||||
                self._errors[field_name] = list(err.messages)
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue
	
	Block a user