encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-01-23 15:54:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix ManyRelatedField.choices

Browse Source 
Use choices from self.child_relation. 
We don't need to repeat ourself because can get out of sync.
This commit is contained in:
Venelin Stoykov 2015-06-29 15:35:55 +03:00
parent 36e4f20111
commit c3c9a712fa
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
rest_framework/relations.py
View File

@ -388,16 +388,4 @@ class ManyRelatedField(Field):
@property
def choices(self):
queryset = self.child_relation.queryset
iterable = queryset.all() if (hasattr(queryset, 'all')) else queryset
items_and_representations = [
(item, self.child_relation.to_representation(item))
for item in iterable
]
return OrderedDict([
(
six.text_type(item_representation),
six.text_type(item) + ' - ' + six.text_type(item_representation)
)
for item, item_representation in items_and_representations
])
return self.child_relation.choices