From 94ec465b0e999a4766a2ee92bb48831ad4cac1b0 Mon Sep 17 00:00:00 2001 From: Kevin Nelson Date: Mon, 24 Jul 2017 16:03:22 +0200 Subject: [PATCH 1/2] Add failling tests for view_name and namespace --- tests/test_model_serializer.py | 41 ++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/tests/test_model_serializer.py b/tests/test_model_serializer.py index ba3edd389..4d1443517 100644 --- a/tests/test_model_serializer.py +++ b/tests/test_model_serializer.py @@ -639,6 +639,47 @@ class TestRelationalFieldMappings(TestCase): """) self.assertEqual(unicode_repr(TestSerializer()), expected) + def test_view_url_custom_view_name(self): + class TestSerializer(serializers.HyperlinkedModelSerializer): + class Meta: + model = RelationalModel + fields = ('url', ) + view_name = 'custom_view_name' + + expected = dedent(""" + TestSerializer(): + url = HyperlinkedIdentityField(view_name='custom_view_name') + """) + self.assertEqual(unicode_repr(TestSerializer()), expected) + + def test_view_url_namespaced(self): + class TestSerializer(serializers.HyperlinkedModelSerializer): + class Meta: + model = RelationalModel + fields = ('url', ) + namespace = 'api' + + expected = dedent(""" + TestSerializer(): + url = HyperlinkedIdentityField(view_name='api:relationalmodel-detail') + """) + self.assertEqual(unicode_repr(TestSerializer()), expected) + + def test_view_url_namespaced_custom_view_name(self): + class TestSerializer(serializers.HyperlinkedModelSerializer): + class Meta: + model = RelationalModel + fields = ('url', ) + view_name = 'custom_view_name' + namespace = 'api' + + expected = dedent(""" + TestSerializer(): + url = HyperlinkedIdentityField(view_name='api:custom_view_name') + """) + self.assertEqual(unicode_repr(TestSerializer()), expected) + + class DisplayValueTargetModel(models.Model): name = models.CharField(max_length=100) From ae5c0a9f16fa003b174bc127eb38c1ad76e470ed Mon Sep 17 00:00:00 2001 From: Kevin Nelson Date: Mon, 24 Jul 2017 16:31:32 +0200 Subject: [PATCH 2/2] Fix lint --- tests/test_model_serializer.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test_model_serializer.py b/tests/test_model_serializer.py index 4d1443517..7a17ee684 100644 --- a/tests/test_model_serializer.py +++ b/tests/test_model_serializer.py @@ -680,7 +680,6 @@ class TestRelationalFieldMappings(TestCase): self.assertEqual(unicode_repr(TestSerializer()), expected) - class DisplayValueTargetModel(models.Model): name = models.CharField(max_length=100)