From c5d6ecc84c5a40f5410bfd89b5a80c4e5a549d25 Mon Sep 17 00:00:00 2001 From: Zoltan Szalai Date: Sat, 25 Apr 2015 16:33:44 +0200 Subject: [PATCH] pass instance to view.get_serializer in metadata's determine_actions method since choices (especially querysets of related fields) can often depend on the instance --- rest_framework/metadata.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rest_framework/metadata.py b/rest_framework/metadata.py index b2c48b816..afef00fe6 100644 --- a/rest_framework/metadata.py +++ b/rest_framework/metadata.py @@ -74,19 +74,23 @@ class SimpleMetadata(BaseMetadata): actions = {} for method in set(['PUT', 'POST']) & set(view.allowed_methods): view.request = clone_request(request, method) + instance = None try: # Test global permissions if hasattr(view, 'check_permissions'): view.check_permissions(view.request) # Test object permissions if method == 'PUT' and hasattr(view, 'get_object'): - view.get_object() + instance = view.get_object() except (exceptions.APIException, PermissionDenied, Http404): pass else: # If user has appropriate permissions for the view, include # appropriate metadata about the fields that should be supplied. - serializer = view.get_serializer() + kwargs = {} + if instance is not None: + kwargs['instance'] = instance + serializer = view.get_serializer(**kwargs) actions[method] = self.get_serializer_info(serializer) finally: view.request = request