encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-08 06:14:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix wrong position of CursorPagination if ordering filed is a BooleanField

Browse Source
This commit is contained in:
pktangyue 2016-01-22 15:05:33 +08:00
parent 909a3e80a1
commit c5e4bb611c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rest_framework/pagination.py
View File

@ -678,6 +678,11 @@ class CursorPagination(BasePagination):
def _get_position_from_instance(self, instance, ordering): def _get_position_from_instance(self, instance, ordering):
attr = getattr(instance, ordering[0].lstrip('-')) attr = getattr(instance, ordering[0].lstrip('-'))
# if ordering is a BooleanField, which mean attr is True/False,
# six.text_type(attr) will return u'True'/u'False'. And this will result
# wrong filter in paginate_queryset()
if isinstance(attr, bool):
return '1' if attr else '0'
return six.text_type(attr) return six.text_type(attr)
def get_paginated_response(self, data): def get_paginated_response(self, data):