From cea907f172c4f640e8bb44e14fab43150fbbc6ad Mon Sep 17 00:00:00 2001 From: Tom Christie Date: Tue, 30 Oct 2012 11:10:23 +0000 Subject: [PATCH] Raise nicer exception if queryset not Set on writable related field. Refs: #338 --- rest_framework/fields.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rest_framework/fields.py b/rest_framework/fields.py index 090a1e373..1d6d760e3 100644 --- a/rest_framework/fields.py +++ b/rest_framework/fields.py @@ -291,6 +291,9 @@ class PrimaryKeyRelatedField(RelatedField): return pk def from_native(self, data): + if self.queryset is None: + raise Exception('Writable related fields must include a `queryset` argument') + try: return self.queryset.get(pk=data) except ObjectDoesNotExist: @@ -374,6 +377,8 @@ class HyperlinkedRelatedField(RelatedField): def from_native(self, value): # Convert URL -> model instance pk # TODO: Use values_list + if self.queryset is None: + raise Exception('Writable related fields must include a `queryset` argument') if value.startswith('http:') or value.startswith('https:'): # If needed convert absolute URLs to relative path