encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-07-29 17:39:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Refactor precondition check into the cache lookup backends

Browse Source
This commit is contained in:
George Hickman 2013-04-02 10:45:47 +01:00
parent 65b16071c4
commit cede7d86a3
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rest_framework/cache_lookups.py
View File

@ -2,6 +2,7 @@
Provides a set of pluggable cache policies.
"""
from django.core.cache import cache
from rest_framework.exceptions import PreconditionFailed
class BaseCacheLookup(object):
@ -37,6 +38,10 @@ class ETagCacheLookup(BaseCacheLookup):
cache.set(key, etag)
return {'ETag': etag}
def precondition_check(self, obj, request):
if self.get_etag(obj) != request.META.get('HTTP_IF_NONE_MATCH'):
raise PreconditionFailed
def resource_unchanged(self, request, key):
etag = cache.get(key)
header = request.META.get('HTTP_IF_NONE_MATCH')

4
rest_framework/views.py
View File

@ -323,10 +323,8 @@ class APIView(View):
raise exceptions.IfMatchMissing
def cache_precondition_check(self, obj, request):
header = request.META.get('HTTP_IF_MATCH')
for cache_lookup in self.get_cache_lookups():
if cache_lookup.get_etag(obj) != header:
raise exceptions.PreconditionFailed
cache_lookup.precondition_check(obj, request)
# Dispatch methods