encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-04-26 03:53:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix: Fix run validation layer with invalid data

Browse Source
This commit is contained in:
David Medina 2013-05-29 12:47:43 +02:00
parent 85fe7197bf
commit d11b55648c
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rest_framework/serializers.py
View File

@ -315,7 +315,8 @@ class BaseSerializer(WritableField):
self._errors = {} self._errors = {}
if data is not None or files is not None: if data is not None or files is not None:
attrs = self.restore_fields(data, files) attrs = self.restore_fields(data, files)
attrs = self.perform_validation(attrs) if attrs is not None:
attrs = self.perform_validation(attrs)
else: else:
self._errors['non_field_errors'] = ['No input provided'] self._errors['non_field_errors'] = ['No input provided']

13
rest_framework/tests/test_validation.py
View File

@ -63,3 +63,16 @@ class TestPreSaveValidationExclusions(TestCase):
# does not have `blank=True`, so this serializer should not validate. # does not have `blank=True`, so this serializer should not validate.
serializer = ShouldValidateModelSerializer(data={'renamed': ''}) serializer = ShouldValidateModelSerializer(data={'renamed': ''})
self.assertEqual(serializer.is_valid(), False) self.assertEqual(serializer.is_valid(), False)
class FieldValidationSerializer(serializers.Serializer):
foo = serializers.CharField()
def validate_foo(self, attrs, source):
raise StandardError("validate_foo was called")
class TestFieldValidationWithInvalidData(TestCase):
def test_validate_foo_was_not_called(self):
serializer = FieldValidationSerializer(data='invalid data')
self.assertFalse(serializer.is_valid())