encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-03 12:00:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

more explicit/obvious error if you try to do writable dotted field.source with a callable final component

Browse Source
This commit is contained in:
Craig de Stigter 2013-08-21 16:54:49 +12:00
parent 0ab70ba170
commit d5d97624f7
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rest_framework/fields.py
View File

@ -69,6 +69,9 @@ def set_component(obj, attr_name, value):
if isinstance(obj, dict): if isinstance(obj, dict):
obj[attr_name] = value obj[attr_name] = value
else: else:
attr = getattr(obj, attr_name)
if six.callable(attr):
raise TypeError("%r.%s is a method; can't set it" % (obj, attr_name))
setattr(obj, attr_name, value) setattr(obj, attr_name, value)
@ -336,10 +339,6 @@ class WritableField(Field):
item = obj item = obj
for component in parts: for component in parts:
item = get_component(item, component) item = get_component(item, component)
if item is None:
raise ValueError(
"can't set %r: component %r is None" % (source, component)
)
set_component(item, last_source_part, value) set_component(item, last_source_part, value)
def field_from_native(self, data, files, field_name, into): def field_from_native(self, data, files, field_name, into):