add support for multiple kwargs in url

This commit is contained in:
Nick Johnson 2013-02-26 17:23:03 -08:00
parent 35331f5820
commit d888228e74
3 changed files with 33 additions and 1 deletions

View File

@ -436,6 +436,11 @@ class HyperlinkedIdentityField(Field):
view_name = self.view_name or self.parent.opts.view_name view_name = self.view_name or self.parent.opts.view_name
kwargs = {self.pk_url_kwarg: obj.pk} kwargs = {self.pk_url_kwarg: obj.pk}
#get any extra kwargs from the view url and make sure we pass them through to reverse
visit = self.context.get('view', None)
if visit:
kwargs.update(visit.kwargs)
if request is None: if request is None:
warnings.warn("Using `HyperlinkedIdentityField` without including the " warnings.warn("Using `HyperlinkedIdentityField` without including the "
"request in the serializer context is due to be deprecated. " "request in the serializer context is due to be deprecated. "

View File

@ -4,7 +4,7 @@ from django.test import TestCase
from django.test.client import RequestFactory from django.test.client import RequestFactory
from rest_framework import generics, status, serializers from rest_framework import generics, status, serializers
from rest_framework.compat import patterns, url from rest_framework.compat import patterns, url
from rest_framework.tests.models import Anchor, BasicModel, ManyToManyModel, BlogPost, BlogPostComment, Album, Photo, OptionalRelationModel from rest_framework.tests.models import Anchor, BasicModel, ManyToManyModel, BlogPost, BlogPostComment, Album, Photo, OptionalRelationModel, ExtraKwargModel
factory = RequestFactory() factory = RequestFactory()
@ -80,6 +80,10 @@ class OptionalRelationDetail(generics.RetrieveUpdateDestroyAPIView):
model_serializer_class = serializers.HyperlinkedModelSerializer model_serializer_class = serializers.HyperlinkedModelSerializer
class ExtraKwargDetail(generics.RetrieveUpdateDestroyAPIView):
model = ExtraKwargModel
model_serializer_class = serializers.HyperlinkedModelSerializer
urlpatterns = patterns('', urlpatterns = patterns('',
url(r'^basic/$', BasicList.as_view(), name='basicmodel-list'), url(r'^basic/$', BasicList.as_view(), name='basicmodel-list'),
url(r'^basic/(?P<pk>\d+)/$', BasicDetail.as_view(), name='basicmodel-detail'), url(r'^basic/(?P<pk>\d+)/$', BasicDetail.as_view(), name='basicmodel-detail'),
@ -92,6 +96,7 @@ urlpatterns = patterns('',
url(r'^albums/(?P<title>\w[\w-]*)/$', AlbumDetail.as_view(), name='album-detail'), url(r'^albums/(?P<title>\w[\w-]*)/$', AlbumDetail.as_view(), name='album-detail'),
url(r'^photos/$', PhotoListCreate.as_view(), name='photo-list'), url(r'^photos/$', PhotoListCreate.as_view(), name='photo-list'),
url(r'^optionalrelation/(?P<pk>\d+)/$', OptionalRelationDetail.as_view(), name='optionalrelationmodel-detail'), url(r'^optionalrelation/(?P<pk>\d+)/$', OptionalRelationDetail.as_view(), name='optionalrelationmodel-detail'),
url(r'^root/(?P<extra_kwarg>\d+)/extrakwarg/(?P<pk>\d+)/$', ExtraKwargDetail.as_view(), name='extrakwargmodel-detail'),
) )
@ -261,3 +266,22 @@ class TestOptionalRelationHyperlinkedView(TestCase):
data=json.dumps(self.data), data=json.dumps(self.data),
content_type='application/json') content_type='application/json')
self.assertEqual(response.status_code, status.HTTP_200_OK) self.assertEqual(response.status_code, status.HTTP_200_OK)
class TestNestedRelationHyperlinkedView(TestCase):
urls = 'rest_framework.tests.hyperlinkedserializers'
def setUp(self):
"""
Create 1 ExtraKwargModel instance.
"""
ExtraKwargModel().save()
self.objects = ExtraKwargModel.objects
self.detail_view = ExtraKwargDetail.as_view()
def test_get_detail_view(self):
"""
GET requests to a detail url with more than one kwarg should still resolve using reverse
"""
response = self.client.get('/root/2/extrakwarg/1/')
self.assertEqual(response.status_code, status.HTTP_200_OK)

View File

@ -123,6 +123,9 @@ class BlankFieldModel(RESTFrameworkModel):
class OptionalRelationModel(RESTFrameworkModel): class OptionalRelationModel(RESTFrameworkModel):
other = models.ForeignKey('OptionalRelationModel', blank=True, null=True) other = models.ForeignKey('OptionalRelationModel', blank=True, null=True)
# Model to test multiple kwargs in url
class ExtraKwargModel(RESTFrameworkModel):
pass
# Model for RegexField # Model for RegexField
class Book(RESTFrameworkModel): class Book(RESTFrameworkModel):