From 7ad414cd60584a7fea505b2c09c800d9f8ba4290 Mon Sep 17 00:00:00 2001 From: Andrea De Marco <24erre@gmail.com> Date: Thu, 8 Mar 2012 11:18:14 +0100 Subject: [PATCH 1/2] Hide hidden fields --- djangorestframework/templates/djangorestframework/base.html | 4 ++-- djangorestframework/views.py | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/djangorestframework/templates/djangorestframework/base.html b/djangorestframework/templates/djangorestframework/base.html index 00ecf8c3c..696beaef2 100644 --- a/djangorestframework/templates/djangorestframework/base.html +++ b/djangorestframework/templates/djangorestframework/base.html @@ -86,7 +86,7 @@

POST {{ name }}

{% csrf_token %} {{ post_form.non_field_errors }} - {% for field in post_form %} + {% for field in post_form.visible_fields %}
{{ field.label_tag }} {{ field }} @@ -108,7 +108,7 @@ {% csrf_token %} {{ put_form.non_field_errors }} - {% for field in put_form %} + {% for field in put_form.visible_fields %}
{{ field.label_tag }} {{ field }} diff --git a/djangorestframework/views.py b/djangorestframework/views.py index 3657fd645..f488a2338 100644 --- a/djangorestframework/views.py +++ b/djangorestframework/views.py @@ -253,7 +253,8 @@ class View(ResourceMixin, RequestMixin, ResponseMixin, AuthMixin, DjangoView): if form is not None: field_name_types = {} for name, field in form.fields.iteritems(): - field_name_types[name] = field.__class__.__name__ + if not field.widget.is_hidden: + field_name_types[name] = field.__class__.__name__ response_obj['fields'] = field_name_types # Note 'ErrorResponse' is misleading, it's just any response # that should be rendered and returned immediately, without any From 2e6e802a9401f8bde335d1433294c40957243393 Mon Sep 17 00:00:00 2001 From: Andrea De Marco <24erre@gmail.com> Date: Fri, 23 Mar 2012 10:16:36 +0100 Subject: [PATCH 2/2] Issue #122 test fix --- djangorestframework/tests/renderers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/djangorestframework/tests/renderers.py b/djangorestframework/tests/renderers.py index 3ed5ab28f..dd1986882 100644 --- a/djangorestframework/tests/renderers.py +++ b/djangorestframework/tests/renderers.py @@ -71,7 +71,7 @@ urlpatterns = patterns('', url(r'^$', MockView.as_view(renderers=[RendererA, RendererB])), url(r'^jsonp/jsonrenderer$', MockGETView.as_view(renderers=[JSONRenderer, JSONPRenderer])), url(r'^jsonp/nojsonrenderer$', MockGETView.as_view(renderers=[JSONPRenderer])), - url(r'^html$', HTMLView.as_view()), + url(r'^html$', HTMLView.as_view(),root='home'), url(r'^html1$', HTMLView1.as_view()), url(r'^api', include('djangorestframework.urls', namespace='djangorestframework')) )