From f010a9553ec7ab1645c2bae4c959a19bb5117a21 Mon Sep 17 00:00:00 2001 From: Tom Christie Date: Tue, 2 Oct 2012 15:39:41 +0100 Subject: [PATCH] Add test to ensure that pk is readonly in PUT requests --- rest_framework/tests/generics.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/rest_framework/tests/generics.py b/rest_framework/tests/generics.py index 79c01f9e2..3c241f427 100644 --- a/rest_framework/tests/generics.py +++ b/rest_framework/tests/generics.py @@ -191,3 +191,15 @@ class TestInstanceView(TestCase): } self.assertEquals(response.status_code, status.HTTP_200_OK) self.assertEquals(response.data, expected) + + def test_put_cannot_set_id(self): + """ + POST requests to create a new object should not be able to set the id. + """ + content = {'id': 999, 'text': 'foobar'} + request = factory.put('/1', json.dumps(content), content_type='application/json') + response = self.view(request, pk=1).render() + self.assertEquals(response.status_code, status.HTTP_200_OK) + self.assertEquals(response.data, {'id': 1, 'text': 'foobar'}) + updated = self.objects.get(id=1) + self.assertEquals(updated.text, 'foobar')