encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2024-11-26 03:23:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

Frameworks throws AssertionError saying you cannot set required=True and read_only=True on editable=False model fields. We should not make the field required if editable=False.

Browse Source
This commit is contained in:
Greg Doermann 2014-08-20 11:00:37 -06:00
parent 21a0a826bb
commit f27a28682b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rest_framework/serializers.py
View File

@ -831,7 +831,7 @@ class ModelSerializer(Serializer):
}
if model_field:
kwargs['required'] = not(model_field.null or model_field.blank)
kwargs['required'] = not(model_field.null or model_field.blank) and model_field.editable
if model_field.help_text is not None:
kwargs['help_text'] = model_field.help_text
if model_field.verbose_name is not None:
@ -854,7 +854,7 @@ class ModelSerializer(Serializer):
"""
kwargs = {}
if model_field.null or model_field.blank:
if model_field.null or model_field.blank and model_field.editable:
kwargs['required'] = False
if isinstance(model_field, models.AutoField) or not model_field.editable:
@ -1110,7 +1110,7 @@ class HyperlinkedModelSerializer(ModelSerializer):
}
if model_field:
kwargs['required'] = not(model_field.null or model_field.blank)
kwargs['required'] = not(model_field.null or model_field.blank) and model_field.editable
if model_field.help_text is not None:
kwargs['help_text'] = model_field.help_text
if model_field.verbose_name is not None: